Integrated: 8347127: CTW fails to build after JDK-8334733
Aleksey Shipilev
shade at openjdk.org
Tue Jan 7 19:36:55 UTC 2025
On Tue, 7 Jan 2025 16:39:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> [JDK-8334733](https://bugs.openjdk.org/browse/JDK-8334733) removed the filter for `ModuleInfoWriter`, which now causes standalone CTW to fail when building:
>
>
> $ export JAVA_HOME=<point to fastdebug build>
> $ export PATH=$JAVA_HOME/bin:$PATH
> $ cd test/hotspot/jtreg/testlibrary/ctw
> $ make
>
> /home/shipilev/shipilev-jdk/build/linux-x86_64-server-fastdebug/images/jdk/bin/../bin/javac --add-exports java.base/jdk.internal.jimage=ALL-UNNAMED --add-exports java.base/jdk.internal.misc=ALL-UNNAMED --add-exports java.base/jdk.internal.reflect=ALL-UNNAMED --add-exports java.base/jdk.internal.access=ALL-UNNAMED -sourcepath src -d build/classes -cp dist/wb.jar @filelist
> ../../../../../test/lib/jdk/test/lib/util/ModuleInfoWriter.java:44: error: package jdk.internal.module is not visible
> import jdk.internal.module.ModuleResolution;
> ^
> (package jdk.internal.module is declared in module java.base, which does not export it to the unnamed module)
> ../../../../../test/lib/jdk/test/lib/util/ModuleInfoWriter.java:45: error: package jdk.internal.module is not visible
> import jdk.internal.module.ModuleTarget;
> ^
> (package jdk.internal.module is declared in module java.base, which does not export it to the unnamed module)
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 2 errors
> make: *** [dist/ctw.jar] Error 1
>
>
> Additional testing:
> - [x] CTW `make` works now
> - [x] Standalone CTW works now
This pull request has now been integrated.
Changeset: e413fc64
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e413fc643c4a58e3c46d81025c3ac9fbf89db4b9
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
8347127: CTW fails to build after JDK-8334733
Reviewed-by: kvn, epeter
-------------
PR: https://git.openjdk.org/jdk/pull/22952
More information about the hotspot-compiler-dev
mailing list