RFR: 8346107: Generators: testing utility for random value generation [v2]
Emanuel Peter
epeter at openjdk.org
Wed Jan 8 09:33:38 UTC 2025
On Tue, 7 Jan 2025 14:07:17 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:
>> test/hotspot/jtreg/testlibrary_tests/generators/tests/TestGenerators.java line 78:
>>
>>> 76: Asserts.assertEQ(g.next(), 4);
>>> 77: Asserts.assertEQ(g.next(), 18);
>>> 78: }
>>
>> It would be nice if you told us / a future person who extends this, what this mocking does, and how it works.
>
> Do you mean specifically how this test here works or how the mocking works? Or both?
Maybe just say what values you feed in, and why it produces the results.
That should hopefully help a future person who tries to extend the test for their own type.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1906878215
More information about the hotspot-compiler-dev
mailing list