RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v4]

[Theo Weidmann]

On Wed, 8 Jan 2025 13:11:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test name
>
> src/hotspot/share/opto/stringopts.cpp line 414:
> 
>> 412: }
>> 413: 
>> 414: PhaseStringOpts::CheckAppendResult PhaseStringOpts::check_append_candidate(CallStaticJavaNode* cnode,
> 
> Using two verbs in succession is a little confusing. At least write `check_and_append_candidate`. Or maybe `append_candidate_if_<something>`.

It's not supposed to be a verb. This methods checks a potential `append` call (a call that might be a call to StringBuilder::append), so it's an *append candidate*. Do you have any suggestions to clarify that?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1907179981