RFR: 8347006: LoadRangeNode floats above array guard in arraycopy intrinsic [v2]

Roland Westrelin roland at openjdk.org
Wed Jan 8 13:39:39 UTC 2025


On Wed, 8 Jan 2025 13:12:37 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> But we need to set up the `slow_region` path, right?

By that you mean have the `slow_region` feed into the uncommon trap that's only created later. It does feel weird that we know we have reached a dead end and we keep trying to add stuff, but ok then.
The other thing is shouldn't the cast be added in `generate_non_array_guard()`? I see it's used elsewhere (`LibraryCallKit::inline_native_getLength()`): couldn't the same bug occur there?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22967#discussion_r1907195835


More information about the hotspot-compiler-dev mailing list