RFR: 8345580: Remove const from Node::_idx which is modified [v2]
Yagmur Eren
duke at openjdk.org
Wed Jan 8 14:54:38 UTC 2025
On Wed, 8 Jan 2025 14:06:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove casting trick in set_idx
>
> Ok, just discussed it with some other engineers:
> Please file a Follow-up RFE. Make `Node::_idx` private, and replace all uses with an accessor.
> You need 2 people with the reviewer role for this, not sure if it is the intention of @eme64
Yes, I realized a bit late that the second one was a committer approval... Thanks for highlighting it @merykitty.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22646#issuecomment-2577863922
More information about the hotspot-compiler-dev
mailing list