RFR: 8347006: LoadRangeNode floats above array guard in arraycopy intrinsic [v2]

[Tobias Hartmann]

On Wed, 8 Jan 2025 14:13:32 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Hmm, maybe `inline_getObjectSize` is affected as well:
>> 
>> https://github.com/openjdk/jdk/blob/afe543414f58a04832d4f07dea88881d64954a0b/src/hotspot/share/opto/library_call.cpp#L8535-L8543
>> 
>> And `LibraryCallKit::inline_native_clone` as well:
>> 
>> https://github.com/openjdk/jdk/blob/afe543414f58a04832d4f07dea88881d64954a0b/src/hotspot/share/opto/library_call.cpp#L5257-L5262
>
>> I guess it's best to fix the `LibraryCallKit::inline_native_getLength` as well, i.e., make it the caller's responsibility to add a cast. What do you think?
> 
> Maybe the methods need to take an extra parameter (the object to cast)?
> Having the cast in the method would lead to less code duplication and a lower risk of forgetting the cast when new calls of the method are added so that's what I would go with unless it's really a pain.

Right, I'll give that a try.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22967#discussion_r1907411409