RFR: 8342393: Promote commutative vector IR node sharing [v4]

[Jatin Bhateja]

On Wed, 8 Jan 2025 13:02:14 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   strict assertion check on commutative operation input count
>
> test/hotspot/jtreg/compiler/vectorapi/VectorCommutativeOperSharingTest.java line 139:
> 
>> 137:         }
>> 138:     }
>> 139: }
> 
> As mentioned above, it would be good to have all combinations of 2 ops, with inputs x and y:
> 
> add(x,x)  with add(x,x)
> add(y,x)  with add(x,x)
> add(x,y)  with add(x,x)
> add(y,y)  with add(x,x)
> add(x,x)  with add(y,x)
> add(y,x)  with add(y,x)
> add(x,y)  with add(y,x)
> add(y,y)  with add(y,x)
> add(x,x)  with add(x,y)
> add(y,x)  with add(x,y)
> add(x,y)  with add(x,y)
> add(y,y)  with add(x,y)
> add(x,x)  with add(y,y)
> add(y,x)  with add(y,y)
> add(x,y)  with add(y,y)
> add(y,y)  with add(y,y)
> 
> At least do this for one operator. All may be a bit much to write... Templates would really be fantastic here... coming soon.

Done, I think templatization will add value in some cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1908211690