RFR: 8342393: Promote commutative vector IR node sharing [v2]
Jatin Bhateja
jbhateja at openjdk.org
Thu Jan 9 06:10:13 UTC 2025
On Wed, 8 Jan 2025 12:48:54 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Where did you add it? I don't see it in the constructor or `add_flag`.
>
> I also wonder: if the flag `is_commutative_operation` is available at the `Node` level, and not just `VectorNode`, then should this logic here not be at `Node::hash` rather than `VectorNode::hash`? Otherwise, the flag should probably be called `is_commutative_vector_operation`, right?
Yes, let's limit this flag to vector IR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1908213214
More information about the hotspot-compiler-dev
mailing list