RFR: 8346107: Generators: testing utility for random value generation [v10]

Emanuel Peter epeter at openjdk.org
Thu Jan 9 12:08:40 UTC 2025


On Thu, 9 Jan 2025 12:03:22 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update ExampleTest.java
>
> test/hotspot/jtreg/testlibrary_tests/generators/tests/TestGenerators.java line 370:
> 
>> 368:             Asserts.assertGreaterThanOrEqual(x, lo);
>> 369:             Asserts.assertLessThanOrEqual(x, hi);
>> 370:         }
> 
> It might be a bit of work, but it could be nice if we had these range checks for all of the restrictable generators.

Well at least those that are safely restrictable without exception.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1908668069


More information about the hotspot-compiler-dev mailing list