RFR: 8346107: Generators: testing utility for random value generation [v9]

[Theo Weidmann]

On Thu, 9 Jan 2025 11:32:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify example test
>
> test/hotspot/jtreg/compiler/lib/generators/Generators.java line 293:
> 
>> 291:     public RestrictableGenerator<Integer> uniformIntsMixedWithSpecials(int weightA, int weightB, int rangeSpecial) {
>> 292:         return mixed(uniformInts(), specialInts(rangeSpecial), weightA, weightB);
>> 293:     }
> 
> I think you should give the weights a better name -> weightUniform and weightSpecial ?

Yup, that really needs to be changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1908732708