RFR: 8347366: RISC-V: Add extension asserts for CMO instructions
Fei Yang
fyang at openjdk.org
Fri Jan 10 02:46:34 UTC 2025
On Thu, 9 Jan 2025 17:50:23 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> Hi please consider this minor improvement.
>
> Sanity tested.
>
> Thanks, Robbin
Nice cleanup! I only see two typos in code comment.
src/hotspot/cpu/riscv/assembler_riscv.hpp line 3094:
> 3092:
> 3093: // This instruction have some security implication.
> 3094: // At this time it's not likley to be enable for user mode.
Suggestion: `// At this time it's not likely to be enabled for user mode.`
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23015#pullrequestreview-2541446072
PR Review Comment: https://git.openjdk.org/jdk/pull/23015#discussion_r1909715422
More information about the hotspot-compiler-dev
mailing list