RFR: 8330851: C2: More efficient TypeFunc creation [v8]
Amit Kumar
amitkumar at openjdk.org
Fri Jan 10 06:45:58 UTC 2025
On Fri, 10 Jan 2025 05:54:32 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into tf_v2
>> - fix test case
>> - new year
>> - fixes code style, restores gc changes
>> - [wip] renamed caches, changed type factories, refactored code
>> - Merge branch 'master' into tf_v2
>> - test fix
>> - Merge branch 'master' into tf_v2
>> - fixing the merge conflict
>> - cover more TypeFunc objects
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/a46ae703...22d97e4c
>
> src/hotspot/share/opto/runtime.cpp line 253:
>
>> 251: const TypeFunc* OptoRuntime::_osr_end_Type = nullptr;
>> 252: const TypeFunc* OptoRuntime::_register_finalizer_Type = nullptr;
>> 253: JFR_ONLY(
>
> For a multi-line case, `#ifdef INCLUDE_JFR` would look better here.
updated.
> src/hotspot/share/opto/runtime.hpp line 311:
>
>> 309: // ======================================================
>> 310:
>> 311: static inline const TypeFunc *new_instance_Type() {
>
> Same: please, spell it as `TypeFunc*` (and subsequent declarations).
updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1909891871
PR Review Comment: https://git.openjdk.org/jdk/pull/21782#discussion_r1909891667
More information about the hotspot-compiler-dev
mailing list