RFR: 8331717: C2: Crash with SIGFPE Because Loop Predication Wrongly Hoists Division Requiring Zero Check [v2]

[Theo Weidmann]

On Thu, 9 Jan 2025 17:18:33 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> @merykitty Thank you for your detailed write-up! @chhagedorn and I talked about it and we also agree with you that there seems to be some fundamental flaw here that needs to be addressed. We should definitely address it soon. It looks like a bigger endeavor though and we should probably file your write-up as RFE so it does not get buried here.
>> 
>> Do you think we should give up on this point fix then? Or do you think it's fine if we merge it and address the underlying cause separately? We still believe that there's no harm in applying this band-aid patch in the way I proposed, while, of course, we have to address the underlying issue here too. 
>> 
>> @rwestrel added pin_array_access_node. Maybe you also want to weigh in on this?
>
> @theoweidmannoracle I think this fix is fine, please go ahead
> 
>> It looks like a bigger endeavor though and we should probably file your write-up as RFE so it does not get buried here.
> 
> I created https://bugs.openjdk.org/browse/JDK-8347365

@merykitty Thanks for opening the RFE!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22666#issuecomment-2582086478