RFR: 8346107: Generators: testing utility for random value generation [v14]

Theo Weidmann tweidmann at openjdk.org
Fri Jan 10 09:01:17 UTC 2025


On Fri, 10 Jan 2025 08:04:31 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> test/hotspot/jtreg/testlibrary_tests/generators/tests/TestGenerators.java line 420:
>> 
>>> 418:         // normal restrictions
>>> 419:         mockSource.checkEmpty().enqueueInteger(4, 6, 4);
>>> 420:         var g1 = mockGS.safeRestrictInt(mockGS.uniformInts(4, 5),2, 5);
>> 
>> Suggestion:
>> 
>>         var g1 = mockGS.safeRestrictInt(mockGS.uniformInts(4, 5), 2, 5);
>
> Thanks for spotting this!

Thanks, I fixed it. IntelliJ's "inlay hints" makes this really hard to see.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1910023554


More information about the hotspot-compiler-dev mailing list