RFR: 8347405: MergeStores with reverse bytes order value [v2]

kuaiwei duke at openjdk.org
Fri Jan 10 13:31:42 UTC 2025


On Fri, 10 Jan 2025 11:17:54 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix as review comments
>
> src/hotspot/share/opto/memnode.cpp line 3270:
> 
>> 3268:          "merged_input_value is either int or long, and new_memory_size is small enough");
>> 3269: 
>> 3270:   if (_value_order == DataOrder::Reverse) {
> 
> Suggestion:
> 
>   if (_value_order == DataOrder::Reverse) {
>     assert(_store->memory_size() == 1, "only implemented for bytes");
> 
> That would be correct, right?

Assert added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23030#discussion_r1910380118


More information about the hotspot-compiler-dev mailing list