RFR: 8347405: MergeStores with reverse bytes order value [v2]

kuaiwei duke at openjdk.org
Mon Jan 13 13:10:41 UTC 2025


On Mon, 13 Jan 2025 03:58:41 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix as review comments
>
> src/hotspot/share/opto/memnode.cpp line 2799:
> 
>> 2797:   //   Forward  -> Forward
>> 2798:   //   Backward -> Backward
>> 2799:   enum ValueOrder { Unknown, Forward, Backward };
> 
> can we update it to: 
> Suggestion:
> 
>   enum ValueOrder : uint8_t { Unknown, Forward, Backward };

The type is added. Thanks for suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23030#discussion_r1913166031


More information about the hotspot-compiler-dev mailing list