RFR: 8347627: Compiler replay tests are failing after JDK-8346990

David Holmes dholmes at openjdk.org
Tue Jan 14 01:42:53 UTC 2025


On Tue, 14 Jan 2025 01:38:03 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The `%#zx` format specifier only prepends `0x` to non-zero values but we need it for all, so switch to manual `0x%zx`. I claim this as a trivial (and urgent) fix.
>> 
>> The only other use of this is in a test where it is fine.
>> 
>> Testing:
>>  - compiler replay tests now pass
>>  - tiers 1-3 (sanity)
>> 
>> Thanks
>
> Yes this looks good.  Thank you so much for finding this bug so quickly!

Thanks for the review @coleenp . I will wait for some more testing to complete just to be safe.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23093#issuecomment-2588579453


More information about the hotspot-compiler-dev mailing list