RFR: 8347627: Compiler replay tests are failing after JDK-8346990 [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Jan 14 02:05:25 UTC 2025


On Tue, 14 Jan 2025 02:01:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The `%#zx` format specifier only prepends `0x` to non-zero values but we need it for all, so switch to manual `0x%zx`. I claim this as a trivial (and urgent) fix.
>> 
>> The only other use of this is in a test where it is fine.
>> 
>> Testing:
>>  - compiler replay tests now pass
>>  - tiers 1-3 (sanity)
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test cases for clarity of difference

Looks good!  Still trivial and urgent.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23093#pullrequestreview-2548437708


More information about the hotspot-compiler-dev mailing list