RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v4]
Emanuel Peter
epeter at openjdk.org
Tue Jan 14 06:42:59 UTC 2025
On Mon, 13 Jan 2025 20:02:16 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 116 commits:
>>
>> - copyright 2025
>> - Merge branch 'master' into JDK-8343685-VPointer-MemPointer
>> - manual merge
>> - fix printing
>> - rename
>> - fix up print
>> - add TestEquivalentInvariants.java
>> - improve documentation
>> - hide parser via delegation
>> - Merge branch 'master' into JDK-8343685-VPointer-MemPointer
>> - ... and 106 more: https://git.openjdk.org/jdk/compare/84e6432b...b64f9295
>
> src/hotspot/share/opto/mempointer.hpp line 620:
>
>> 618:
>> 619: private:
>> 620: NOT_PRODUCT( const TraceMemPointer& _trace; )
>
> Why you prefer `_trace` to be first and not last?
Ah, I think in a previous version I needed the _trace while initializing other parts... but I don't any more.
Nice catch!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1914319474
More information about the hotspot-compiler-dev
mailing list