RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v4]

[Emanuel Peter]

On Tue, 14 Jan 2025 06:34:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/memnode.cpp line 2951:
>> 
>>> 2949: #endif
>>> 2950:   const MemPointer pointer_use(NOT_PRODUCT(trace COMMA) use_store);
>>> 2951:   const MemPointer pointer_def(NOT_PRODUCT(trace COMMA) def_store);
>> 
>> Why you swapped arguments? Main argument will different in debug vs product VMs.
>
> Ok, I will put `NOT_PRODUCT` last. I think it was somehow easier, but cannot remember why now.

Ah, yes. It was because of parameters with default values, see other comments. But I'm now handling it different after your comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1914354669