RFR: 8341293: Split field loads through Nested Phis [v2]
Christian Hagedorn
chagedorn at openjdk.org
Tue Jan 14 17:46:55 UTC 2025
On Tue, 14 Jan 2025 17:16:08 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> These compiler flags are common for all the tests.
>
> Hmm, in my experience these flags are not really necessary, and rather a restriction we would like to remove if possible.
>
> Is there an argument why they cannot be moved to the IR rules with `applyIf...`?
I agree with Emanuel. The problem, especially with `vm.flagless`, is that this test is not run in higher tiers anymore where we pass in different flags. It is generally better to work with `applyIf`. Then the test is still run with other flag combos but IR rules are not checked depending on the used flags (not on the IR framework whitelist)/machine (not having the required CPU features).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21270#discussion_r1915337421
More information about the hotspot-compiler-dev
mailing list