RFR: 8342393: Promote commutative vector IR node sharing [v7]
Jatin Bhateja
jbhateja at openjdk.org
Wed Jan 15 04:13:24 UTC 2025
On Tue, 14 Jan 2025 08:21:32 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> GHA fix
>
> src/hotspot/share/opto/vectornode.hpp line 191:
>
>> 189: AddVBNode(Node* in1, Node* in2, const TypeVect* vt) : VectorNode(in1,in2,vt) {
>> 190: add_flag(Node::Flag_is_commutative_vector_oper);
>> 191: }
>
> So does this still work if these vector nodes are predicated which may append another mask input in future?
Thanks @XiaohongGong , comment addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1915915349
More information about the hotspot-compiler-dev
mailing list