RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v4]
Vladimir Kozlov
kvn at openjdk.org
Wed Jan 15 06:53:48 UTC 2025
On Wed, 15 Jan 2025 06:35:36 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> I have few comments.
>
>> @vnkozlov thanks for having a look at it! I think I have addressed all your points.
>
> I still have concern about `cmp()` with NaN values. See my comment.
> @vnkozlov thanks for your comments. I just pushed a fix - does that address your concerns? Or would you want more than explanatory comment for `cmp`? If you want something more: what would you consider a good idea? Rename `cmp` to `cmp_where_NaN_before_nonNaN_and_NaN_eq_NaN`?
New comment looks fine to me. No need to rename method.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21926#issuecomment-2591776077
More information about the hotspot-compiler-dev
mailing list