RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v6]
Emanuel Peter
epeter at openjdk.org
Wed Jan 15 07:19:35 UTC 2025
On Wed, 15 Jan 2025 06:58:57 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More fixes for vnkozlov
>
> Now we need to decide what to do with commented tests. It is not clear your intention what to do with them.
>> "This one is array, and for some reason does not currently parse pointers sufficiently well to vectorize:"
>
> Do you plan to fix it (in an other changes)? Then you need to say it in comment.
>
> What happens with a test which rules are commented (as in your change)? Does it run or not? Does it ignore results if it runs? Why to run it then?
@vnkozlov I removed (deleted, not just commented any more) the IR rules. I left the comment to investigate it with JDK-8330274. And even without IR rules, we at least still have result verification, i.e. that we have correct execution.
@vnkozlov Thank you for reviewing and the approval 😊
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21926#issuecomment-2591788201
PR Comment: https://git.openjdk.org/jdk/pull/21926#issuecomment-2591789881
More information about the hotspot-compiler-dev
mailing list