RFR: 8346107: Generators: testing utility for random value generation [v20]

Christian Hagedorn chagedorn at openjdk.org
Wed Jan 15 09:16:42 UTC 2025


On Wed, 15 Jan 2025 08:45:14 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> This PR is a refactoring and partial rewrite of https://github.com/openjdk/jdk/pull/22716 by @eme64. The goals remain the same:
>> 
>>> For verification testing, it is often critical to generate "interesting" values, to provoke overflows, NaN, etc. And to generate these values in the correct distribution to trigger certain optimizations.
>>> 
>>> I would like to start a collection of such generators, that can then be used in testing.
>>> 
>>> The goal is to grow this collection in the future, and add new types. For example byte, char, short, or even Float16.
>>> 
>>> This will be helpful for the Template framework [JDK-8344942](https://bugs.openjdk.org/browse/JDK-8344942), but also other tests.
>>> 
>>> Related PR, for value verification: https://github.com/openjdk/jdk/pull/22715
>> 
>> The refactoring makes use of generics, rendering the generators library more flexible by default, by allowing it work with arbitrary types (with special features for Comparable types), improving the composability of different generators and streamlining the client API for simplicity. This allows test authors to quickly compose their own distributions and generators if necessary. An overview of this functionality is provided in the `Generators` javadoc.
>
> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename to powerOfTwos

Two more minor comments, then it's good to go in from my side :-)

test/hotspot/jtreg/compiler/lib/generators/AnyBitsDoubleGenerator.java line 2:

> 1: /*
> 2:  * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.

Since these are all new files, you can directly use 2025 and drop 2024.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22941#pullrequestreview-2551946760
PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1916203105


More information about the hotspot-compiler-dev mailing list