RFR: 8346107: Generators: testing utility for random value generation [v16]

Christian Hagedorn chagedorn at openjdk.org
Wed Jan 15 09:16:43 UTC 2025


On Wed, 15 Jan 2025 08:32:35 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/generators/Generators.java line 33:
>> 
>>> 31: 
>>> 32: /**
>>> 33:  * The generators class provides a set of random generator functions for testing.
>> 
>> Nice description. A suggestion: It is sometimes difficult to distinguish between generators in general and the class `Generators` itself. How about using `{@code Generators}` when talking about the class itself?
>
> I think I will just capitalize it to clarify it

I was mainly mentioning it since Generators is often used at the beginning of the sentence where it's not immediately clear if you mean the class or not. It could help with the reading flow. But I leave it up to you to decide.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22941#discussion_r1916200590


More information about the hotspot-compiler-dev mailing list