RFR: 8347489: RISC-V: Misaligned memory access with COH [v4]

Hamlin Li mli at openjdk.org
Wed Jan 15 14:17:37 UTC 2025


On Mon, 13 Jan 2025 10:05:31 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8347489
>>  - Comment
>>  - Fix assertions
>>  - Add assertions
>>  - Comment
>>  - 8347489: RISC-V: Misaligned memory access with COH
>
> Thanks for the patch.
> Can you post the performance data in description?
> And some minor comments.

> @Hamlin-Li Thanks for the suggestions. I have updated accordingly. Note that base_offset is 12 and 16 bytes respectively w/wo COH. And I have also added some specjbb2005 scores in PR description for reference.

Thank you posting the data!
As G1 is the default one, can you run the specjbb with G1? And it would be good to list both critial and max value for specjbb.
BTW, there are also some string comparison tests in jmh, e.g. StringCompareToDifferentLength and so on.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23053#issuecomment-2592967128


More information about the hotspot-compiler-dev mailing list