RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v6]

[Emanuel Peter]

On Wed, 15 Jan 2025 12:19:38 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> src/hotspot/share/opto/vectorization.hpp line 844:
>> 
>>> 842:   }
>>> 843: 
>>> 844:   bool has_same_invar_and_iv_scale_as(const VPointer& other) const {
>> 
>> Okay, I see that we should probably use either "invariant" or "invar" consistently in method names. I guess it's still fine for temporary variables to use "invar". But when reading code it could be more clear when using "invariant". But I leave it up to you to decide - having a better big picture if this is improving the readability or not.
>
> Should we name this ...same_invar_summands... to be more precise?

Renamed it to `has_same_invar_summands_and_iv_scale_as`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1917843824