RFR: 8330851: C2: More efficient TypeFunc creation [v8]

Amit Kumar amitkumar at openjdk.org
Thu Jan 16 09:45:39 UTC 2025


On Fri, 10 Jan 2025 05:59:39 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>> 
>>  - Merge branch 'master' into tf_v2
>>  - fix test case
>>  - new year
>>  - fixes code style, restores gc changes
>>  - [wip] renamed caches, changed type factories, refactored code
>>  - Merge branch 'master' into tf_v2
>>  - test fix
>>  - Merge branch 'master' into tf_v2
>>  - fixing the merge conflict
>>  - cover more TypeFunc objects
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/a46ae703...22d97e4c
>
>> I can follow the same approach I followed for `CallNode` and `ArrayCopyNode` structure, if that would be fine ? I also feel that same change can be done for `CallNode` and `ArrayCopyNode` as they also need their own initializer. I am fine with both, fixing it here or fixing with separate RFE.
> 
> Up to you. No strong preferences on my side. I'm fine with the current shape of the patch.

I guess I need approval one more time or probably a new review. After @iwanowww's approval I pushed a commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21782#issuecomment-2595031081


More information about the hotspot-compiler-dev mailing list