RFR: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing [v6]
Theo Weidmann
tweidmann at openjdk.org
Thu Jan 16 09:46:45 UTC 2025
On Sat, 11 Jan 2025 02:29:36 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Theo Weidmann has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Address comments
>> - Actually return top
>> - Update divnode.cpp
>
> Sorry for being late here. What do you think about using a general-purpose `CallPureNode` that represents a call not reading or writing external modifiable states? Apart from `ModF` and `ModD`, there are several other nodes that may benefit from this such as the trigonometric functions, svml calls, etc. A `CallPureNode` does not have input and output control or memory, which makes it more susceptible to GVN and deadcode elimination, as well as allowing it to be more freely scheduled.
@merykitty I think it's a good idea. Opened an RFE here: https://bugs.openjdk.org/browse/JDK-8347901
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22786#issuecomment-2595032205
More information about the hotspot-compiler-dev
mailing list