RFR: 8346607: IGV: Support drag-and-drop for opening graph files [v3]

Tobias Hartmann thartmann at openjdk.org
Thu Jan 16 10:12:45 UTC 2025


On Wed, 15 Jan 2025 11:29:14 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> Adds the ability to drag-and-drop graph files into IGV.
>> 
>> A welcome screen invites users to drag and drop files:
>> 
>> https://github.com/user-attachments/assets/e08810bd-4e75-42d0-9507-fb24366803f9
>> 
>> The welcome screen disappears while any graphs have been imported (via opening a file or via socket) and reappears automatically if no graphs are imported in the workspace (that is, if the list on the left-hand side is completely empty).
>> 
>> Furthermore, graphs can be dropped at any time in the areas in the green boxes in the image below. The reason only these areas work is due to the unfortunate way in which Apache NetBeans handles drag and drop events, as many components just consume events they cannot process without offering any apparent way to customize the drop behavior.
>> 
>> <img width="2091" alt="Screenshot 2025-01-10 at 16 11 13" src="https://github.com/user-attachments/assets/558d57fd-01f3-4cfb-a70f-a9573cb729e9" />
>
> Theo Weidmann has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8346607-igv-drop-files
>  - Clean up
>  - Fix whitespace
>  - Improve show hide logic
>  - Implement file drag and drop

Marked as reviewed by thartmann (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23040#pullrequestreview-2555449554


More information about the hotspot-compiler-dev mailing list