RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v5]

[Emanuel Peter]

On Thu, 16 Jan 2025 12:41:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make code more clear
>
> src/hotspot/share/opto/stringopts.cpp line 619:
> 
>> 617:           // - If we found an append, that's perfect. Nothing further to do.
>> 618:           // - If this is a call to an unrelated method, validate_mem_flow() (and validate_control_flow())
>> 619:           //   will later check if this call prevents the optimization. So nothing to do here.
> 
> Ok, so why do we continue on and not return yet?

Maybe "We can keep looking for more appends"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1918448089