RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v13]

Emanuel Peter epeter at openjdk.org
Thu Jan 16 16:04:59 UTC 2025


On Thu, 16 Jan 2025 15:02:14 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor to has_invar_summands and print invar and fix non-product guards
>
> src/hotspot/share/opto/vectorization.hpp line 714:
> 
>> 712: //   pointer = base + invar + iv_scale * iv + con
>> 713: //
>> 714: //   invar = SUM(invar_summands)
> 
> Would it make sense to add `iv_summand` here as well since you mention it below? I.e. something like:
> 
> //   pointer = base + invar + iv_summand + con
> // with
> //   invar = SUM(invar_summands)
> //   iv_summand = iv_scale * iv

Good idea!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1918810947


More information about the hotspot-compiler-dev mailing list