RFR: 8342393: Promote commutative vector IR node sharing [v10]

[Emanuel Peter]

On Fri, 17 Jan 2025 06:32:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review suggestions incorporated
>
> test/hotspot/jtreg/compiler/vectorapi/VectorCommutativeOperSharingTest.java line 123:
> 
>> 121:     public void testVectorIRSharingDriver2() {
>> 122:         for (int i = 0; i < I_SPECIES.loopBound(LENGTH); i += I_SPECIES.length()) {
>> 123:             testVectorIRSharing2(i);
> 
> Adding some result verification would be nice. Because now you only check that you get the right number of instructions - but that does not mean that they are connected correctly. Result verification could help here.
> 
> See:
> https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/verify/Verify.java
> https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/testlibrary_tests/verify/examples/TestVerifyInCheckMethod.java
> 
> Also, for random value generation we hope to use this in the future:
> https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/generators/Generators.java

You don't have to use Generators here, and it is up to you if you want to use `Verify.checkEQ` or do your own comparisons - use what is more convenient for you for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1919628227