RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v5]

Theo Weidmann tweidmann at openjdk.org
Fri Jan 17 08:25:39 UTC 2025


On Thu, 16 Jan 2025 12:39:01 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make code more clear
>
> src/hotspot/share/opto/stringopts.cpp line 480:
> 
>> 478: //   .append("bar")
>> 479: //   .append(123)
>> 480: //   .toString(); // "foobar123"+
> 
> Is the "+" on purpose here?

Thanks, for spotting this. Must be a typo

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22537#discussion_r1919727703


More information about the hotspot-compiler-dev mailing list