RFR: 8347987: Bad ifdef in 8330851
Robbin Ehn
rehn at openjdk.org
Fri Jan 17 12:08:40 UTC 2025
On Fri, 17 Jan 2025 11:12:41 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> Hi, please consider.
>
> We use "#if INCLUDE_xxx" everywhere else.
> Currently I get this compilation error:
>
> src/hotspot/share/opto/runtime.cpp:2006:41: error: ‘make_notify_jvmti_vthread_Type’ was not declared in this scope; did you mean ‘_notify_jvmti_vthread_Type’?
> 2006 | _notify_jvmti_vthread_Type = make_notify_jvmti_vthread_Type();
>
>
> Only compiled tested, thanks!
> Sorry for this trouble. Btw on which architecture this build failed ?
>
> Some `#ifdef INCLUDE_[gc]` related are still in the codebase, like here (`c1_LIR.hpp`):
>
> ```c++
> #ifdef INCLUDE_ZGC
> , begin_opXLoadBarrierTest
> , lir_xloadbarrier_test
> , end_opXLoadBarrierTest
> #endif
> ```
Risc-V, yes. Sorry I only meant for "if INCLUDE_JFR/JVMTI".
@stefank thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23172#issuecomment-2598221552
More information about the hotspot-compiler-dev
mailing list