RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v14]

Emanuel Peter epeter at openjdk.org
Sat Jan 18 05:50:52 UTC 2025


On Fri, 17 Jan 2025 13:49:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Batch 2 for Christian
>
> src/hotspot/share/opto/mempointer.hpp line 829:
> 
>> 827: };
>> 828: 
>> 829: class MemPointerParser : public StackObj {
> 
> Maybe a quick class comment to summarize the input and output could be helpful here.

I wrote this, lmk if that is what you wanted:

// Utility class.
// MemPointerParser::parse takes a MemNode (load or store) and computes its MemPointer.
// It temporarily allocates dynamic data structures (GrowableArray) in the resource
// area. This way, the computed MemPointer does not have to have any dynamic data
// structures and can be copied freely by value.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1920983501


More information about the hotspot-compiler-dev mailing list