RFR: 8343685: C2 SuperWord: refactor VPointer with MemPointer [v19]

Quan Anh Mai qamai at openjdk.org
Mon Jan 20 07:37:56 UTC 2025


On Mon, 20 Jan 2025 07:34:35 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix guard
>
> src/hotspot/share/opto/superwordVTransformBuilder.cpp line 144:
> 
>> 142:     const VPointer& scalar_p = _vloop_analyzer.vpointers().vpointer(p0->as_Load());
>> 143:     const VPointer vector_p(scalar_p.make_with_size(scalar_p.size() * pack_size));
>> 144:     vtn = new (_vtransform.arena()) VTransformLoadVectorNode(_vtransform, pack_size, vector_p);
> 
> You should use `::new` here

Ah no my mistake this is not a placement `new` but an arena `new`, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21926#discussion_r1921918550


More information about the hotspot-compiler-dev mailing list