RFR: 8346836: C2: Introduce a way to verify the correctness of ConstraintCastNodes at runtime [v3]

[Emanuel Peter]

On Wed, 22 Jan 2025 08:12:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move test to a new file, add block_comment
>
> test/hotspot/jtreg/compiler/c2/TestVerifyConstraintCasts.java line 39:
> 
>> 37:  * @summary Run with -Xcomp to test -XX:+StressGCM -XX:VerifyConstraintCasts=2 in debug builds.
>> 38:  *
>> 39:  * @run main/othervm/timeout=300 -Xbatch -Xcomp -XX:+StressGCM -XX:VerifyConstraintCasts=2 compiler.c2.TestVerifyConstraintCasts
> 
> Suggestion:
> 
>  * @run main/othervm/timeout=300 -Xbatch -Xcomp -XX:VerifyConstraintCasts=2 compiler.c2.TestVerifyConstraintCasts
> 
> I would have left the `StressGCM` out - we already add that in our CI testing for some runs anyway. But I suppose it does not super hurt to have it in either.

What was your reason to put it in?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22880#discussion_r1924869905