RFR: 8342393: Promote commutative vector IR node sharing [v10]

[Jatin Bhateja]

On Tue, 21 Jan 2025 08:11:10 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> @vnkozlov @jatin-bhateja Ok, then we can leave it at the current `Flag_is_commutative_vector_op`. @jatin-bhateja please file a follow-up RFE and link it with this issue. You can assign it to me if you want - I will try to find someone to take care of the scalar refactoring.
>> 
>> Please add some result verification to the tests, as commented separately.
>> 
>> Once that is done, I can run testing and approve the PR.
>
>> Flag_is_commutative_vector_op
> 
> Hi @eme64 , 
> I have extended IR test points to check functional correctness using Verify.checkEQ.
> Created a follow-up JBS entry for scalar IR communing [https://bugs.openjdk.org/browse/JDK-8348134](https://bugs.openjdk.org/browse/JDK-8348134)
> For now, I have assigned it to myself. Please feel free to re-assign it; I can help with the reviews. 
> 
> Please go ahead with test runs.
> 
> Best Regards,
> Jatin

> @jatin-bhateja thanks for the test updates!
> 
> I have some more comments about the VM changes - I think we can improve the code slightly and make it more understandable :)
> 
> And thanks for filing the follow-up RFE for scalar nodes. I did not understand: do you want to work on that or not?

![image](https://github.com/user-attachments/assets/3b50ad09-f5b0-4ea9-af13-c0df229fb051)


Hey @eme64 , 

All your comments are addressed.
Kindly verify, on RFE: I have assigned it to myself and plan to address it after integrating my inflight PRs.

In case you have some major refactoring plans, please re-assign it to yourself and I can help with reviews.

Best Regards,
Jatin

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22863#issuecomment-2606907301