RFR: 8342393: Promote commutative vector IR node sharing [v10]

Emanuel Peter epeter at openjdk.org
Wed Jan 22 12:35:45 UTC 2025


On Wed, 22 Jan 2025 10:50:51 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>>> Flag_is_commutative_vector_op
>> 
>> Hi @eme64 , 
>> I have extended IR test points to check functional correctness using Verify.checkEQ.
>> Created a follow-up JBS entry for scalar IR communing [https://bugs.openjdk.org/browse/JDK-8348134](https://bugs.openjdk.org/browse/JDK-8348134)
>> For now, I have assigned it to myself. Please feel free to re-assign it; I can help with the reviews. 
>> 
>> Please go ahead with test runs.
>> 
>> Best Regards,
>> Jatin
>
>> @jatin-bhateja thanks for the test updates!
>> 
>> I have some more comments about the VM changes - I think we can improve the code slightly and make it more understandable :)
>> 
>> And thanks for filing the follow-up RFE for scalar nodes. I did not understand: do you want to work on that or not?
> 
> ![image](https://github.com/user-attachments/assets/3b50ad09-f5b0-4ea9-af13-c0df229fb051)
> 
> 
> Hey @eme64 , 
> 
> All your comments are addressed.
> Kindly verify, on RFE: I have assigned it to myself and plan to address it after integrating my inflight PRs.
> 
> In case you have some major refactoring plans, please re-assign it to yourself and I can help with reviews.
> 
> Best Regards,
> Jatin

@jatin-bhateja Thanks for the merge, testing is running...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22863#issuecomment-2607129870


More information about the hotspot-compiler-dev mailing list