RFR: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat [v4]

[Theo Weidmann]

On Thu, 16 Jan 2025 09:46:22 GMT, Theo Weidmann <tweidmann at openjdk.org> wrote:

>> Looks promising. Though I did not work with string-opts before, so a little hard for me to give a proper review. If you want/need me to review, a few more annotations with github comments would help. Otherwise I'll just leave it at the drive-by comments ;)
>
> @eme64 @vnkozlov Could you take another look at the latest changes? They are mostly of cosmetic nature based on @eme64's suggestions.

> @theoweidmannoracle, I see failures in your latest internal testing.

Closed repo was out of sync. Latest testing has no new failures.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22537#issuecomment-2609051506