RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v11]

[Jatin Bhateja]

On Thu, 23 Jan 2025 08:14:13 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review suggestions incorporated.
>
> src/hotspot/share/opto/library_call.cpp line 8670:
> 
>> 8668: 
>> 8669:   const TypeInstPtr* box_type = _gvn.type(argument(0))->isa_instptr();
>> 8670:   if (box_type == nullptr || box_type->const_oop() == nullptr) {
> 
> Hi, this is not a review comment.
> Just curious, to continue the following code path why does `box_type` must have a valid `const_oop`?

@Hamlin-Li , Class types are passed as constant oop, this check is added for argument validation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22754#discussion_r1926564701