RFR: 8342393: Promote commutative vector IR node sharing [v13]

Jatin Bhateja jbhateja at openjdk.org
Thu Jan 23 08:36:04 UTC 2025


On Wed, 22 Jan 2025 13:02:03 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8342393
>>  - Review suggestions incorporated.
>>  - Adding functional verification to test points using Verify.checkEQ
>>  - Review suggestions incorporated
>>  - Generalizing vector size constraints covering different AVX levels and KNLSetting
>>  - GHA fix
>>  - Review comments resolutions.
>>  - removing spaces
>>  - Adding functional and performance tests
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8342393
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/1450b8b0...f21e30f1
>
> Just got a gcc internal compiler error on `linux-x64-ri`:
> 
> .../open/src/hotspot/share/precompiled/precompiled.hpp:61:
> .../open/src/hotspot/share/utilities/copy.hpp:362:2: internal compiler error: in gt_pch_save, at ggc-common.cc:674
> [2025-01-22T12:48:11,911Z]   362 | };
> [2025-01-22T12:48:11,911Z]       |  ^
> [2025-01-22T12:48:12,841Z] 0x6e0432 gt_pch_save(_IO_FILE*)
> [2025-01-22T12:48:12,841Z] 	/home/mikael/src/jdk/jdk/devkit/jdk/open/build/devkit/src/gcc-13.2.0/gcc/ggc-common.cc:674
> [2025-01-22T12:48:12,867Z] 0x96b865 c_common_write_pch()
> [2025-01-22T12:48:12,867Z] 	/home/mikael/src/jdk/jdk/devkit/jdk/open/build/devkit/src/gcc-13.2.0/gcc/c-family/c-pch.cc:175
> [2025-01-22T12:48:12,885Z] 0x7b56e5 c_parse_final_cleanups()
> [2025-01-22T12:48:12,885Z] 	/home/mikael/src/jdk/jdk/devkit/jdk/open/build/devkit/src/gcc-13.2.0/gcc/cp/decl2.cc:4940
> [2025-01-22T12:48:12,885Z] 0x96b490 c_common_parse_file()
> [2025-01-22T12:48:12,885Z] 	/home/mikael/src/jdk/jdk/devkit/jdk/open/build/devkit/src/gcc-13.2.0/gcc/c-family/c-opts.cc:1266
> [2025-01-22T12:48:12,925Z] Please submit a full bug report, with preprocessed source (by using -freport-bug).
> 
> Ah, it was raised as https://bugs.openjdk.org/browse/JDK-8338470

Hi @eme64 , Kindly share the result of you test runs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22863#issuecomment-2609157482


More information about the hotspot-compiler-dev mailing list