RFR: 8342393: Promote commutative vector IR node sharing [v14]

Jatin Bhateja jbhateja at openjdk.org
Thu Jan 23 10:29:50 UTC 2025


On Thu, 23 Jan 2025 10:21:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding a missed check to skip over commoning of predicated vector operations
>
> src/hotspot/share/opto/phaseX.cpp line 75:
> 
>> 73:   // the result of the operation is corresponding lane of its first operand.
>> 74:   //   i.e. RES = VEC1.lanewise(OPER, VEC2, MASK) is semantically equivalent to
>> 75:   //        RES = VEC1.BLEND(VEC1.lanewise(OPER, VEC2), MASK)
> 
> I think you are missing an argument to the BLEND, right? `VEC1` should be in there for the `false` case.

BLEND is operating over VEC1 and result of VEC1.lanewise(OPER, VEC2) under influence of MASK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1926730714


More information about the hotspot-compiler-dev mailing list