RFR: 8342393: Promote commutative vector IR node sharing [v14]
Jatin Bhateja
jbhateja at openjdk.org
Thu Jan 23 18:45:16 UTC 2025
On Thu, 23 Jan 2025 13:57:28 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
> > > I'm a little sad that `is_commutative_vector_operation` does not mean that it is actually commutative now. Rather, it means: "it is commutative if it is not predicated"
> >
> >
> > Hey @eme64 , Your comments are addressed.
>
> What was you answer to my concern that `is_commutative_vector_operation` does not mean that it is actually commutative (with the conter example of predicated case)?
>
> I'm still confused about your comment: does `BLEND` not have 3 operands? You closed my thread as resolved without really answering all of my questions - I'm still confused 😅
Hi @eme64 ,
I thought more on this and moving away from a based solution looks appealing.
Let me know if this looks fine to you.
> I'm still confused about your comment: does `BLEND` not have 3 operands? You closed my thread as resolved without really answering all of my questions - I'm still confused 😅
I does, two vectors and a mask under which blending happens, I have updated the comments for clarity.
Best,
Jatin
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22863#issuecomment-2610660924
More information about the hotspot-compiler-dev
mailing list