RFR: 8347645: C2: XOR bounded value handling blocks constant folding [v4]

Johannes Graham duke at openjdk.org
Thu Jan 23 22:07:49 UTC 2025


On Thu, 23 Jan 2025 08:19:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Johannes Graham has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix test names
>
> src/hotspot/share/opto/addnode.cpp line 1041:
> 
>> 1039:       const TypeLong* t2x = TypeLong::make(0, round_down_power_of_2(r1->_hi) + (round_down_power_of_2(r1->_hi) - 1), r1->_widen);
>> 1040:       return t1x->meet(t2x);
>> 1041:     }
> 
> Is there a reason why the `BOOL` check is not here as well? Does `long` not have one as well? This could be a follow-up RFE of course.

Long doesn't have a BOOL. Happily since the boolean test is covered by the more general check, we're good here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23089#discussion_r1927743673


More information about the hotspot-compiler-dev mailing list