[External] : Re: Is the section name _RDATA in jsvml.dll intended?

[Viswanathan, Sandhya]

Hi Julian,

Thanks for catching this. You are correct, it should have been:

_RDATA  SEGMENT     READONLY PAGE   'DATA'

Best Regards,
Sandhya
________________________________
From: dean.long at oracle.com <dean.long at oracle.com>
Sent: Wednesday, January 22, 2025 5:44 PM
To: Julian Waters <tanksherman27 at gmail.com>; hotspot-compiler-dev at openjdk.org <hotspot-compiler-dev at openjdk.org>; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
Subject: Re: [External] : Re: Is the section name _RDATA in jsvml.dll intended?


Hi Sandhya.  Can you answer this question?

On 1/18/25 10:50 PM, Julian Waters wrote:
I briefly checked the _RDATA SEGMENT directive in some of the jsvml.dll source files and it does seem like the READ attribute is not in the right place, in some places it comes before the "align" attribute instead of after. I'm not sure whether the Intel compiler meant READONLY before align, or if it meant to set READ after, as mentioned by the MASM documentation: https://learn.microsoft.com/en-us/cpp/assembler/masm/segment?view=msvc-170<https://urldefense.com/v3/__https://learn.microsoft.com/en-us/cpp/assembler/masm/segment?view=msvc-170__;!!ACWV5N9M2RV99hQ!PpK1i1x6SNT-4xG2FQ2nuaQ6KQ_ODUE_s8rfd85w0Fo9-s6diy2Vb54W8t0upi7W6F-18BfUmNYDAOT927itQjQ$>

An example of what I mean is this:
_RDATA  SEGMENT     READ PAGE   'DATA'

best regards,
Julian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-compiler-dev/attachments/20250124/47662778/attachment.htm>