RFR: 8347489: RISC-V: Misaligned memory access with COH [v4]
Fei Yang
fyang at openjdk.org
Mon Jan 27 04:01:47 UTC 2025
On Wed, 15 Jan 2025 15:01:59 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2474:
>>
>>> 2472:
>>> 2473: // strL is 8-byte aligned
>>> 2474: __ ld(tmpLval, Address(strL));
>>
>> This should also be a `load_long_misaligned`?
>
> And the below one in this function?
Good catch! I think I missed the second one. Fixed.
For the first one, I think we are OK as `strL` is ensured to be 8-byte aligned by the caller [1].
[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp#L2526
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23053#discussion_r1929964636
More information about the hotspot-compiler-dev
mailing list