RFR: 8346664: C2: Optimize mask check with constant offset [v3]
Emanuel Peter
epeter at openjdk.org
Mon Jan 27 07:51:49 UTC 2025
On Thu, 23 Jan 2025 07:04:00 GMT, Matthias Ernst <duke at openjdk.org> wrote:
>> Matthias Ernst has updated the pull request incrementally with one additional commit since the last revision:
>>
>> (c)
>
> What's left to do here? Thanks!
@mernst-github Thanks for the test update!
I see there is still discussion around this line:
` return zeros > 0 && ((((jlong)1) << zeros) > mask_t->hi_as_long() && mask_t->lo_as_long() >= 0);`
It is indeed difficult to read. Maybe even just some clever names of temporary variables could help. But I leave that up to you ;)
Ping me when you want me to run testing and review again :)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22856#issuecomment-2615044394
More information about the hotspot-compiler-dev
mailing list